hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Steve Loughran (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-13823) s3a rename: fail if dest file exists
Date Tue, 17 Jan 2017 11:01:26 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-13823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15825850#comment-15825850

Steve Loughran commented on HADOOP-13823:

I'm throwing an exception, from innerRename((): but I'm catching it in {{rename()}}. That
{{RenameException()}} propagates the text and return code. It's intended to be used when we
add a public rename/3, in which case the rename will forward the exception all the way up.

Are you seeing, on a branch which has this patch in, an exception propagating? Or is your
statement that "an exception is being raised" based on code review of the patch?

> s3a rename: fail if dest file exists
> ------------------------------------
>                 Key: HADOOP-13823
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13823
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs/s3
>    Affects Versions: 2.7.3
>            Reporter: Steve Loughran
>            Assignee: Steve Loughran
>            Priority: Blocker
>             Fix For: 2.8.0, 3.0.0-alpha2
>         Attachments: HADOOP-13813-branch-2-001.patch, HADOOP-13823-branch-2-002.patch
> HIVE-15199 shows that s3a allows rename onto an existing file, which is something HDFS,
azure and s3n do not permit (though file:// does). This is breaking bits of Hive, is an inconsistency
with HDFS and a regression compared to s3n semantics.
> I propose: rejecting the rename on a file -> file rename if the destination exists
(easy) and changing the s3a.xml contract file to declare the behavior change; this is needed
for {{AbstractContractRenameTest.testRenameFileOverExistingFile}} to handle the changed semantics.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org

View raw message