hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-12908) Make JvmPauseMonitor a singleton
Date Wed, 04 Jan 2017 21:49:58 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-12908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15799455#comment-15799455
] 

Hadoop QA commented on HADOOP-12908:
------------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m  0s{color} | {color:blue}
Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red}  0m  4s{color} | {color:red}
HADOOP-12908 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute
for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | HADOOP-12908 |
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12794331/HADOOP-12908-003.patch
|
| Console output | https://builds.apache.org/job/PreCommit-HADOOP-Build/11363/console |
| Powered by | Apache Yetus 0.5.0-SNAPSHOT   http://yetus.apache.org |


This message was automatically generated.



> Make JvmPauseMonitor a singleton
> --------------------------------
>
>                 Key: HADOOP-12908
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12908
>             Project: Hadoop Common
>          Issue Type: Improvement
>    Affects Versions: 2.7.2
>            Reporter: John Zhuge
>            Assignee: John Zhuge
>            Priority: Minor
>         Attachments: HADOOP-12908-001.patch, HADOOP-12908-002.patch, HADOOP-12908-003.patch
>
>
> Make JvmPauseMonitor a singleton just as JvmMetrics because there is no use case to run
multiple instances per JVM. {{TestMetrics$setPauseMonitor}} becomes obsolete. Initialization
code for various components can be simplified.
> For example, this code segment
> {code}
>     pauseMonitor = new JvmPauseMonitor();
>     addService(pauseMonitor);
>     jm.setPauseMonitor(pauseMonitor);
> {code}
> can be replaced with
> {code}
>     addService(JvmPauseMonitor.getInstance());
> {code}
> And this code segment
> {code}
>       pauseMonitor = new JvmPauseMonitor();
>       pauseMonitor.init(config);
>       pauseMonitor.start();
>       metrics.getJvmMetrics().setPauseMonitor(pauseMonitor);
> {code}
> can be replaced with
> {code}
>       pauseMonitor = JvmPauseMonitor.getInstance();
>       pauseMonitor.init(config);
>       pauseMonitor.start();
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message