hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Akira Ajisaka (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-13835) Move Google Test Framework code from mapreduce to hadoop-common
Date Thu, 01 Dec 2016 08:10:58 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-13835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15711277#comment-15711277
] 

Akira Ajisaka commented on HADOOP-13835:
----------------------------------------

Would you remove the following setting in rat plugin?
{code:title=hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/pom.xml}
            <!-- gtest has a compatible license -->
            <exclude>src/main/native/gtest/**/*</exclude>
{code}
I don't think the following changes are needed.
{code:title=CMakeLists.txt}
-include_directories(SYSTEM ${SRC}/gtest/include)
+# include_directories(SYSTEM ${SRC}/gtest/include)
 
-set(CMAKE_MACOSX_RPATH TRUE)
 set(CMAKE_BUILD_WITH_INSTALL_RPATH TRUE)
-set(CMAKE_INSTALL_RPATH_USE_LINK_PATH TRUE)
{code}
Adding {{set(CMAKE_INSTALL_RPATH_USE_LINK_PATH TRUE)}} is needed for me to run `mvn test -Pnative`
in hadoop-mapreduce-client-nativetask module successfully on CentOS 7.2.

> Move Google Test Framework code from mapreduce to hadoop-common
> ---------------------------------------------------------------
>
>                 Key: HADOOP-13835
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13835
>             Project: Hadoop Common
>          Issue Type: Task
>            Reporter: Varun Vasudev
>            Assignee: Varun Vasudev
>         Attachments: HADOOP-13835.001.patch, HADOOP-13835.002.patch, HADOOP-13835.003.patch
>
>
> The mapreduce project has Google Test Framework code to allow testing of native libraries.
This should be moved to hadoop-common so that other projects can use it as well.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message