hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Zhuge (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (HADOOP-13597) Switch KMS from Tomcat to Jetty
Date Fri, 02 Dec 2016 17:31:58 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-13597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15715569#comment-15715569
] 

John Zhuge edited comment on HADOOP-13597 at 12/2/16 5:31 PM:
--------------------------------------------------------------

[~aw] Found mistake in {{hadoop-kms.sh}} for Patch 002 where everything is in {{hadoop_subcommand_kms}}.
Should be:
{code}
if [[ "${HADOOP_SHELL_EXECNAME}" = hadoop ]]; then
  hadoop_add_profile kms
  hadoop_add_subcommand "kms" "run KMS, the Key Management Server"
fi

function _kms_hadoop_init
{
  # init variables
}

function hadoop_subcommand_kms
{
  # Called by bin/hadoop to provide subcommand case statement if any
  HADOOP_SUBCMD_SUPPORTDAEMONIZATION=true
  HADOOP_CLASSNAME=org.apache.hadoop.crypto.key.kms.server.KMSHttpServer
}

function _kms_hadoop_finalize
{
  # Called in finalize phase, all env vars are settled
  hadoop_add_param HADOOP_OPTS "-Dkms.config.dir=" \
    "-Dkms.config.dir=${HADOOP_CONF_DIR}"
  hadoop_add_param HADOOP_OPTS "-Dkms.log.dir=" \
    "-Dkms.log.dir=${HADOOP_LOG_DIR}"
}
{code}
The 3 functions are called in this order:
# _kms_hadoop_init
# hadoop_subcommand_kms
# _kms_hadoop_finalize


was (Author: jzhuge):
[~aw] Found mistake in {{hadoop-kms.sh}} for Patch 002 where everything is in {{hadoop_subcommand_kms}}.
Should be:
{code}
if [[ "${HADOOP_SHELL_EXECNAME}" = hadoop ]]; then
  hadoop_add_profile kms
  hadoop_add_subcommand "kms" "run KMS, the Key Management Server"
fi

function _kms_hadoop_init
{
  # init variables
}

function hadoop_subcommand_kms
{
  # Called by bin/hadoop to provide subcommand case statement if any
  HADOOP_SUBCMD_SUPPORTDAEMONIZATION=true
  HADOOP_CLASSNAME=org.apache.hadoop.crypto.key.kms.server.KMSHttpServer
}

function _kms_hadoop_finalize
{
  # Called in finalize phase, all env vars are settled
  hadoop_add_param HADOOP_OPTS "-Dkms.config.dir=" \
    "-Dkms.config.dir=${HADOOP_CONF_DIR}"
  hadoop_add_param HADOOP_OPTS "-Dkms.log.dir=" \
    "-Dkms.log.dir=${HADOOP_LOG_DIR}"
}
{code}
The 3 functions are called in this order:
# _kms_hadoop_init
# hadoop_subcommand_kms
# _kmd_hadoop_finalize

> Switch KMS from Tomcat to Jetty
> -------------------------------
>
>                 Key: HADOOP-13597
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13597
>             Project: Hadoop Common
>          Issue Type: New Feature
>          Components: kms
>    Affects Versions: 2.6.0
>            Reporter: John Zhuge
>            Assignee: John Zhuge
>         Attachments: HADOOP-13597.001.patch, HADOOP-13597.002.patch
>
>
> The Tomcat 6 we are using will reach EOL at the end of 2017. While there are other good
options, I would propose switching to {{Jetty 9}} for the following reasons:
> * Easier migration. Both Tomcat and Jetty are based on {{Servlet Containers}}, so we
don't have change client code that much. It would require more work to switch to {{JAX-RS}}.
> * Well established.
> * Good performance and scalability.
> Other alternatives:
> * Jersey + Grizzly
> * Tomcat 8
> Your opinions will be greatly appreciated.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message