Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Date: Thu, 3 Nov 2016 14:42:58 +0000 (UTC)
From: "Sean Busbey (JIRA)" <jira@apache.org>
To: common-issues@hadoop.apache.org
Message-ID: <JIRA.13017541.1478159014000.173056.1478184178357@Atlassian.JIRA>
In-Reply-To: <JIRA.13017541.1478159014000@Atlassian.JIRA>
References: <JIRA.13017541.1478159014000@Atlassian.JIRA> <JIRA.13017541.1478159014896@arcas>
Subject: [jira] [Commented] (HADOOP-13789) Hadoop Common includes generated
 test protos in both jar and test-jar
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Thu, 03 Nov 2016 14:43:00 -0000


    [ https://issues.apache.org/jira/browse/HADOOP-13789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15632928#comment-15632928 ] 

Sean Busbey commented on HADOOP-13789:
--------------------------------------

I didn't add any tests because this fixes a condition of the build's working files. The only test I can think to add would be checking generated main artifacts to make sure there aren't classes named {{TestXxxx}}, but that 1) seems excessive and 2) won't be detected as including a test by yetus.

> Hadoop Common includes generated test protos in both jar and test-jar
> ---------------------------------------------------------------------
>
>                 Key: HADOOP-13789
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13789
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: build, common
>            Reporter: Sean Busbey
>            Assignee: Sean Busbey
>         Attachments: HADOOP-13789.1.patch
>
>
> Right now our ProtocMojo always adds source directories to the main compile phase and we use it in hadoop-common to both generate main files as well as test files. This results in the test files getting added to both our test jar (correct) and our main jar (not correct).
> We should either add a main-vs-test flag to the configuration for ProtocMojo or make a ProtocTestMojo that always adds as a test sources.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org