Return-Path: <common-issues-return-121531-archive-asf-public=cust-asf.ponee.io@hadoop.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id 30D01200BC3
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Fri,  4 Nov 2016 01:30:00 +0100 (CET)
Received: by cust-asf.ponee.io (Postfix)
	id 2F78F160B0B; Fri,  4 Nov 2016 00:30:00 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id 7603D160AFF
	for <archive-asf-public@cust-asf.ponee.io>; Fri,  4 Nov 2016 01:29:59 +0100 (CET)
Received: (qmail 76566 invoked by uid 500); 4 Nov 2016 00:29:58 -0000
Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:common-issues-help@hadoop.apache.org>
List-Unsubscribe: <mailto:common-issues-unsubscribe@hadoop.apache.org>
List-Post: <mailto:common-issues@hadoop.apache.org>
List-Id: <common-issues.hadoop.apache.org>
Delivered-To: mailing list common-issues@hadoop.apache.org
Received: (qmail 76543 invoked by uid 99); 4 Nov 2016 00:29:58 -0000
Received: from arcas.apache.org (HELO arcas) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 04 Nov 2016 00:29:58 +0000
Received: from arcas.apache.org (localhost [127.0.0.1])
	by arcas (Postfix) with ESMTP id 5E2432C2A67
	for <common-issues@hadoop.apache.org>; Fri,  4 Nov 2016 00:29:58 +0000 (UTC)
Date: Fri, 4 Nov 2016 00:29:58 +0000 (UTC)
From: "Mingliang Liu (JIRA)" <jira@apache.org>
To: common-issues@hadoop.apache.org
Message-ID: <JIRA.13017135.1478078435000.182380.1478219398382@Atlassian.JIRA>
In-Reply-To: <JIRA.13017135.1478078435000@Atlassian.JIRA>
References: <JIRA.13017135.1478078435000@Atlassian.JIRA> <JIRA.13017135.1478078435238@arcas>
Subject: [jira] [Commented] (HADOOP-13792) Stackoverflow for schemeless
 defaultFS with trailing slash
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394
archived-at: Fri, 04 Nov 2016 00:30:00 -0000


    [ https://issues.apache.org/jira/browse/HADOOP-13792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15634772#comment-15634772 ] 

Mingliang Liu commented on HADOOP-13792:
----------------------------------------

{quote}
Uri abc.com/ is parsed into scheme=null, authority=null, path=abc.com/; while abc.com into scheme=hdfs, authority=abc.com, path=.
{quote}
The {{fixName()}} will fix the scheme name for the URI and the default is hdfs.

I think the patch makes sense. Let's commit to {{trunk}} and {{branch-2}}, though the error case is incompatible, which should not be a real problem. I want to ping [~aw] for 2nd opinion.

In order to really break compatibility, in the long term I think we can refuse any non fully-qualified URI so we don't have to {{fixName()}}.

The checkstyle warnings are related.

> Stackoverflow for schemeless defaultFS with trailing slash
> ----------------------------------------------------------
>
>                 Key: HADOOP-13792
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13792
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: fs
>    Affects Versions: 2.7.2
>            Reporter: Darius Murawski
>            Assignee: John Zhuge
>             Fix For: 3.0.0-alpha2
>
>         Attachments: HADOOP-13792.001.patch
>
>
> Command: hadoop fs -fs 172.16.12.79/ -mkdir -p /usr/hduser
> Results in a Stack Overflow
> {code}
> Exception in thread "main" java.lang.StackOverflowError
> 	at java.lang.String.indexOf(String.java:1503)
> 	at java.net.URI$Parser.scan(URI.java:2951)
> 	at java.net.URI$Parser.parseHierarchical(URI.java:3104)
> 	at java.net.URI$Parser.parse(URI.java:3063)
> 	at java.net.URI.<init>(URI.java:588)
> 	at java.net.URI.create(URI.java:850)
> 	at org.apache.hadoop.fs.FileSystem.getDefaultUri(FileSystem.java:180)
> 	at org.apache.hadoop.fs.FileSystem.get(FileSystem.java:172)
> 	at org.apache.hadoop.fs.FileSystem.get(FileSystem.java:357)
> 	at org.apache.hadoop.fs.FileSystem.get(FileSystem.java:172)
> 	at org.apache.hadoop.fs.FileSystem.get(FileSystem.java:357)
>         (...)
> {code}
> The Problem is the Slash at the End of the IP Address. When I remove it, the command is executed correctly.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org