hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Zhuge (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-13851) hadoop-openstack should build tests without auth-keys.xml
Date Wed, 30 Nov 2016 19:06:58 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-13851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15709446#comment-15709446
] 

John Zhuge commented on HADOOP-13851:
-------------------------------------

Essentially apply HADOOP-13446 to swift?
Is it possible to backport HADOOP-13446 to 2.7 and 2.6?

> hadoop-openstack should build tests without auth-keys.xml
> ---------------------------------------------------------
>
>                 Key: HADOOP-13851
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13851
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: fs/swift, test
>            Reporter: John Zhuge
>            Assignee: John Zhuge
>            Priority: Minor
>
> hadoop-openstack require the existence of file {{src/test/resources/auth-keys.xml}} to
run the tests. With the use of {{maven.test.skip}} in pom.xml, the non-existence of auth-keys.xml
also prevents building the test code. Unfortunately this leads to delayed detection of build
problems in test code, e.g., introduced by a mistake in backports.
> {code}
>     <profile>
>       <id>tests-off</id>
>       <activation>
>         <file>
>           <missing>src/test/resources/auth-keys.xml</missing>
>         </file>
>       </activation>
>       <properties>
>         <maven.test.skip>true</maven.test.skip>
>       </properties>
>     </profile>
>     <profile>
>       <id>tests-on</id>
>       <activation>
>         <file>
>           <exists>src/test/resources/auth-keys.xml</exists>
>         </file>
>       </activation>
>       <properties>
>         <maven.test.skip>false</maven.test.skip>
>       </properties>
>     </profile>
> {code}
> Section {{Skipping by Default}} in http://maven.apache.org/surefire/maven-surefire-plugin/examples/skipping-test.html
suggests a different solution. Any time you want to run tests, you must do 2 things instead
of 1:
> * Copy auth-keys.xml to src/test/resources
> * Run {{mvn install}} with the extra {{-DskipTests=false}}
> Would like the community to weigh in on this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message