hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Zhuge (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (HADOOP-13824) FsShell can suppress the real error if no error message is present
Date Thu, 24 Nov 2016 08:43:58 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-13824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15692630#comment-15692630
] 

John Zhuge edited comment on HADOOP-13824 at 11/24/16 8:43 AM:
---------------------------------------------------------------

Patch 002:
* Add test utilility class {{SystemErrCapture}} and {{TeePrintStream}}
* Wei-Chiu's suggestion

[~stevel@apache.org], can not use {{ex.toString()}} because it would break {{testDFSWithInvalidCommmand}}.


was (Author: jzhuge):
Patch 002:
* Add test utilility class {{SystemErrCapture}} and {{TeePrintStream}}
* Wei-Chiu's suggestion

[~stevel@apache.org], can not use {{ex.toString()}} because it would break {{testDFSWithInvalidCommmand}}

> FsShell can suppress the real error if no error message is present
> ------------------------------------------------------------------
>
>                 Key: HADOOP-13824
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13824
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: fs
>    Affects Versions: 2.7.1, 2.7.3
>            Reporter: Rob Vesse
>            Assignee: John Zhuge
>              Labels: supportability
>         Attachments: HADOOP-13824.001.patch, HADOOP-13824.002.patch
>
>
> The {{FsShell}} error handling assumes in {{displayError()}} that the {{message}} argument
is not {{null}}. However in the case where it is this leads to a NPE which results in suppressing
the actual error information since a higher level of error handling kicks in and just dumps
the stack trace of the NPE instead.
> e.g.
> {noformat}
> Exception in thread "main" java.lang.NullPointerException
> 	at org.apache.hadoop.fs.FsShell.displayError(FsShell.java:304)
> 	at org.apache.hadoop.fs.FsShell.run(FsShell.java:289)
> 	at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:70)
> 	at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:84)
> 	at org.apache.hadoop.fs.FsShell.main(FsShell.java:340)
> {noformat}
> This is deeply unhelpful because depending on what the underlying error was there may
be no stack dumped/logged for it (as HADOOP-7114 provides) since {{FsShell}} doesn't explicitly
dump traces for {{IllegalArgumentException}} which appears to be the underlying cause of my
issue.  Line 289 is where {{displayError()}} is called for {{IllegalArgumentException}} handling
and that catch clause does not log the error.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message