hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Wang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-13789) Hadoop Common includes generated test protos in both jar and test-jar
Date Wed, 09 Nov 2016 00:32:58 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-13789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15649341#comment-15649341
] 

Andrew Wang commented on HADOOP-13789:
--------------------------------------

It looks like the build was aborted. Precommit can have a hard time with big patches.

Considering v4 just fixes the whitespace nit, I'm going to go ahead and commit it. This will
hopefully free up HADOOP-11804 too.

> Hadoop Common includes generated test protos in both jar and test-jar
> ---------------------------------------------------------------------
>
>                 Key: HADOOP-13789
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13789
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: build, common
>            Reporter: Sean Busbey
>            Assignee: Sean Busbey
>         Attachments: HADOOP-13789.1.patch, HADOOP-13789.2.patch, HADOOP-13789.3.patch,
HADOOP-13789.4.patch
>
>
> Right now our ProtocMojo always adds source directories to the main compile phase and
we use it in hadoop-common to both generate main files as well as test files. This results
in the test files getting added to both our test jar (correct) and our main jar (not correct).
> We should either add a main-vs-test flag to the configuration for ProtocMojo or make
a ProtocTestMojo that always adds as a test sources.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message