hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sean Busbey (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-13789) Hadoop Common includes generated test protos in both jar and test-jar
Date Thu, 03 Nov 2016 20:28:58 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-13789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15634138#comment-15634138
] 

Sean Busbey commented on HADOOP-13789:
--------------------------------------

{quote}
Would this be cleaner as a new "protoc-test" goal rather than a flag? 
{quote}

I'm not sure. a new goal requires a new class, so definitely more code to do it as a different
goal. I don't think it'd take me long to do as two goals, so let me know if you'd prefer that.

{quote}
There are also other test protoc invocations in other modules besides hadoop-common, e.g.
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/pom.xml.
Do these need to be updated as well?
{quote}

Interesting. Each of those examples I can find now is outputting the generated files into
{{generated-sources/java}} instead of {{generated-test-sources/java}}. I think this means
those sources *only* end up in the main artifact and not the test artifact at all. That could
be intentional or could be a mistake. I'll confirm that they're only in one place. I suspect
someone more familiar with YARN would be needed to determine if they ought be in the test
jar instead of the main artifact.

> Hadoop Common includes generated test protos in both jar and test-jar
> ---------------------------------------------------------------------
>
>                 Key: HADOOP-13789
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13789
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: build, common
>            Reporter: Sean Busbey
>            Assignee: Sean Busbey
>         Attachments: HADOOP-13789.1.patch
>
>
> Right now our ProtocMojo always adds source directories to the main compile phase and
we use it in hadoop-common to both generate main files as well as test files. This results
in the test files getting added to both our test jar (correct) and our main jar (not correct).
> We should either add a main-vs-test flag to the configuration for ProtocMojo or make
a ProtocTestMojo that always adds as a test sources.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message