hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Brahma Reddy Battula (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-13605) Clean up FileSystem javadocs, logging; improve diagnostics on FS load
Date Thu, 24 Nov 2016 16:02:58 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-13605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15693617#comment-15693617
] 

Brahma Reddy Battula commented on HADOOP-13605:
-----------------------------------------------


Following test fails after this check-in , Raised HADOOP-13833 to track.

{noformat}
org.junit.ComparisonFailure: expected:<...ileSystem for scheme[: null]> but was:<...ileSystem
for scheme[ "null"]>
	at org.junit.Assert.assertEquals(Assert.java:115)
	at org.junit.Assert.assertEquals(Assert.java:144)
	at org.apache.hadoop.fs.SymlinkBaseTest.testCreateLinkUsingPartQualPath2(SymlinkBaseTest.java:574)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44)
	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
	at org.junit.internal.runners.statements.FailOnTimeout$StatementThread.run(FailOnTimeout.java:74)
{noformat}

 *REF:*  https://builds.apache.org/job/hadoop-qbt-trunk-java8-linux-x86/235/testReport/junit/org.apache.hadoop.fs/TestSymlinkHdfsFileSystem/testCreateLinkUsingPartQualPath2/

> Clean up FileSystem javadocs, logging; improve diagnostics on FS load
> ---------------------------------------------------------------------
>
>                 Key: HADOOP-13605
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13605
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: fs
>    Affects Versions: 2.8.0
>            Reporter: Steve Loughran
>            Assignee: Steve Loughran
>             Fix For: 2.9.0, 3.0.0-alpha2
>
>         Attachments: HADOOP-13605-004.patch, HADOOP-13605-005.patch, HADOOP-13605-branch-2-001.patch,
HADOOP-13605-branch-2-002.patch, HADOOP-13605-branch-2-003.patch
>
>
> We can't easily debug FS instantiation problems as there isn't much detail in what was
going on.
> We can add more logging, but cannot simply switch {{FileSystem.LOG}} to SLF4J —the
class is used in too many places, including tests which cast it. Instead, add a new private
SLF4J Logger, {{LOGGER}} and switch logging to it. 
> While working in the base FileSystem class, take the opportunity to clean up javadocs
and comments
> # add the list of exceptions, including indicating which base classes throw UnsupportedOperationExceptions
> # cut bits in the comments which are not true
> The outcome of this patch is that IDEs shouldn't highlight most of the file as flawed
in some way or another



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message