hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-13603) Ignore package line length checkstyle rule
Date Tue, 01 Nov 2016 12:20:58 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-13603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15625290#comment-15625290
] 

Hudson commented on HADOOP-13603:
---------------------------------

SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10743 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/10743/])
HADOOP-13603. Ignore package line length checkstyle rule. Contributed by (aajisaka: rev 5b577f43a269caeee776a59695427985d0cd1697)
* (edit) hadoop-build-tools/src/main/resources/checkstyle/checkstyle.xml


> Ignore package line length checkstyle rule
> ------------------------------------------
>
>                 Key: HADOOP-13603
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13603
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: build
>            Reporter: Shane Kumpf
>            Assignee: Shane Kumpf
>             Fix For: 2.8.0, 3.0.0-alpha2
>
>         Attachments: HADOOP-13603.001.patch
>
>
> The packages related to the DockerLinuxContainerRuntime all exceed the 80 char line length
limit enforced by checkstyle. This causes every build to fail with a -1. I would like to exclude
this rule from causing a failure.
> {code}
> ./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/linux/runtime/docker/DockerCommandExecutor.java:17:package
org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.runtime.docker;: Line is
longer than 80 characters (found 88).
> ./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/linux/runtime/docker/DockerContainerStatusHandler.java:17:package
org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.runtime.docker;: Line is
longer than 80 characters (found 88).
> ./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/linux/runtime/docker/package-info.java:23:package
org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.runtime.docker;: Line is
longer than 80 characters (found 88).
> ./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/linux/privileged/MockPrivilegedOperationCaptor.java:17:package
org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.privileged;: Line is longer
than 80 characters (found 84).
> ./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/linux/runtime/DockerRuntimeTestingUtils.java:17:package
org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.runtime;: Line is longer
than 80 characters (found 81).
> ./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/linux/runtime/docker/MockDockerContainerStatusHandler.java:17:package
org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.runtime.docker;: Line is
longer than 80 characters (found 88).
> ./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/linux/runtime/docker/TestDockerCommandExecutor.java:17:package
org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.runtime.docker;: Line is
longer than 80 characters (found 88).
> ./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/linux/runtime/docker/TestDockerContainerStatusHandler.java:17:package
org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.runtime.docker;: Line is
longer than 80 characters (found 88).
> {code}
> Alternatively, we could look to restructure the packages here, but I question what value
this check really provides.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message