hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Xiao Chen (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-13597) Switch KMS from Tomcat to Jetty
Date Wed, 30 Nov 2016 01:05:59 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-13597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15707117#comment-15707117
] 

Xiao Chen commented on HADOOP-13597:
------------------------------------

Thanks for working on this [~jzhuge].

Some review comments aside from your todos:
- Suggest to name the new config key names XXXX_KEY, to be more consistent with HDFS/Common
way.
- Nice we're loading envvars for compatibility. It'll make upgrades less painful. OTOH, could
you add some text in the {{Loaded env}} logs to indicate this is a deprecated way, and user
should user configuration files instead?
- {{kms-default.xml}} has some duplicate key names (hadoop.kms.authentication.signer.secret.provider.zookeeper.XXX).
- This exists before your patch, but good to fix along: kms-default.xml has some escaped chars
(&quot;) in configuration.
- {{hadoop.kms.authentication.signer.secret.provider.zookeeper.auth.type}} defaults to {{none}}
before. We should keep that unchanged. The {{kerberos}} default value also doesn't work, it
should be {{sasl}}
- We should add basic testing to {{KMSHttpServer}}
- Had a quick run, kms.log seems record every request/response. By default this shouldn't
be logged.
- After clean install kms.log appears to be at TRACE level. Suggest to make it INFO.

> Switch KMS from Tomcat to Jetty
> -------------------------------
>
>                 Key: HADOOP-13597
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13597
>             Project: Hadoop Common
>          Issue Type: New Feature
>          Components: kms
>    Affects Versions: 2.6.0
>            Reporter: John Zhuge
>            Assignee: John Zhuge
>         Attachments: HADOOP-13597.001.patch
>
>
> The Tomcat 6 we are using will reach EOL at the end of 2017. While there are other good
options, I would propose switching to {{Jetty 9}} for the following reasons:
> * Easier migration. Both Tomcat and Jetty are based on {{Servlet Containers}}, so we
don't have change client code that much. It would require more work to switch to {{JAX-RS}}.
> * Well established.
> * Good performance and scalability.
> Other alternatives:
> * Jersey + Grizzly
> * Tomcat 8
> Your opinions will be greatly appreciated.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message