hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aaron Fabbri (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-13449) S3Guard: Implement DynamoDBMetadataStore.
Date Wed, 30 Nov 2016 02:44:58 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-13449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15707310#comment-15707310
] 

Aaron Fabbri commented on HADOOP-13449:
---------------------------------------

This fixes that failed unit test for me:

{code}
--- a/hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/MockS3ClientFactory.java
+++ b/hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/MockS3ClientFactory.java
@@ -41,9 +41,8 @@
   @Override
   public AmazonDynamoDBClient createDynamoDBClient(
       URI uri, com.amazonaws.regions.Region region) throws IOException {
-    final DefaultS3ClientFactory factory = new DefaultS3ClientFactory();
-    factory.setConf(getConf());
-    return factory.createDynamoDBClient(uri, region);
+    throw new IOException("Purposely failing to create DynamoDB client"
+      + " for unit test.");
   }
{code}

Also noticed a spot we need to fix the exception thrown (supposed to be an IOException):

{code}
    @Override
    public AmazonDynamoDBClient createDynamoDBClient(URI fsUri, Region region)
        throws IOException {
{code}
...
{code}
          String msg = "Incorrect DynamoDB endpoint: "  + endPoint;
          LOG.error(msg, e);
          throw new IllegalArgumentException(msg, e);
        }
      }
{code}

I have a number of integration test failures I'll be working through next.  BTW, I'm happy
to submit a follow-up (v11) patch with these things if that would help, just shout.

> S3Guard: Implement DynamoDBMetadataStore.
> -----------------------------------------
>
>                 Key: HADOOP-13449
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13449
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs/s3
>            Reporter: Chris Nauroth
>            Assignee: Mingliang Liu
>         Attachments: HADOOP-13449-HADOOP-13345.000.patch, HADOOP-13449-HADOOP-13345.001.patch,
HADOOP-13449-HADOOP-13345.002.patch, HADOOP-13449-HADOOP-13345.003.patch, HADOOP-13449-HADOOP-13345.004.patch,
HADOOP-13449-HADOOP-13345.005.patch, HADOOP-13449-HADOOP-13345.006.patch, HADOOP-13449-HADOOP-13345.007.patch,
HADOOP-13449-HADOOP-13345.008.patch, HADOOP-13449-HADOOP-13345.009.patch, HADOOP-13449-HADOOP-13345.010.patch
>
>
> Provide an implementation of the metadata store backed by DynamoDB.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message