hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mingliang Liu (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HADOOP-13427) Eliminate needless uses of FileSystem.exists, isFile, isDirectory
Date Tue, 01 Nov 2016 21:33:58 GMT

     [ https://issues.apache.org/jira/browse/HADOOP-13427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Mingliang Liu updated HADOOP-13427:
-----------------------------------
    Attachment: HADOOP-13427.003.patch

+1 the v2 patch.

I rebased the patch from {{trunk}} branch as the v2 patch can not apply cleanly. It may be
interesting if [~stevel@apache.org] can +1 for your own patch, see [#HADOOP-13427.003.patch].

I don't quite get the following code snippet:
{code:title=SwiftTestUtils.java}
496	      throw (IOException)new FileNotFoundException(message + ": not found "
497	          + path + " in " + path.getParent() + ": " + e + " -- "
498	           + ls(fileSystem, path.getParent())).initCause(e);
{code}
and
{code:title=FileSystemApplicationHistoryStore.java}
658	    try {
659	      fs.getFileStatus(applicationHistoryFile);
660	    } catch (FileNotFoundException e) {
661	      throw (FileNotFoundException) new FileNotFoundException
662	          ("History file for application " + appId + " is not found: " + e)
663	          .initCause(e);
{code}

> Eliminate needless uses of FileSystem.exists, isFile, isDirectory 
> ------------------------------------------------------------------
>
>                 Key: HADOOP-13427
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13427
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: fs
>    Affects Versions: 2.8.0
>            Reporter: Steve Loughran
>            Assignee: Steve Loughran
>            Priority: Minor
>         Attachments: HADOOP-13427-001.patch, HADOOP-13427-002.patch, HADOOP-13427.003.patch
>
>
> We're cleaning up Hive and Spark's use of FileSystem.exists, because it is often the
case we see code of exists+open, exists+delete, when the exists probe is needless. Against
object stores, expensive needless.
> Hadoop can set an example here by stripping them out. It will also show where there are
opportunities to optimise things better and/or improve reporting.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message