Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 1C371200BB1 for ; Thu, 20 Oct 2016 00:23:01 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 1AEEA160AFB; Wed, 19 Oct 2016 22:23:01 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 63B22160AEA for ; Thu, 20 Oct 2016 00:23:00 +0200 (CEST) Received: (qmail 88211 invoked by uid 500); 19 Oct 2016 22:22:59 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 87869 invoked by uid 99); 19 Oct 2016 22:22:58 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 19 Oct 2016 22:22:58 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id A76BA2C4C7D for ; Wed, 19 Oct 2016 22:22:58 +0000 (UTC) Date: Wed, 19 Oct 2016 22:22:58 +0000 (UTC) From: "Aaron Fabbri (JIRA)" To: common-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HADOOP-13736) Change PathMetadata to hold S3AFileStatus instead of FileStatus. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Wed, 19 Oct 2016 22:23:01 -0000 [ https://issues.apache.org/jira/browse/HADOOP-13736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15590048#comment-15590048 ] Aaron Fabbri commented on HADOOP-13736: --------------------------------------- Why not cast as needed and keep it the base type? The ADLS folks indicated they were interested in using MetadataStore, but this change would break that. In LocalMetadataStore, I have a single special case for s3a due to the isEmptyDirectory flag in S3AFileStatus. I have a flag {{isS3A}} in the LocalMetadataStore and I cast as needed when it is true. > Change PathMetadata to hold S3AFileStatus instead of FileStatus. > ---------------------------------------------------------------- > > Key: HADOOP-13736 > URL: https://issues.apache.org/jira/browse/HADOOP-13736 > Project: Hadoop Common > Issue Type: Sub-task > Components: fs/s3 > Reporter: Lei (Eddy) Xu > Assignee: Lei (Eddy) Xu > > {{S3AFileStatus}} is implemented differently with {{FileStatus}}, for instance {{S3AFileStatus#isEmptyDirectory()}} is not implemented in {{FileStatus()}}. And {{access_time}}, {{block_replication}}, {{owner}}, {{group}} and a few other fields are not meaningful in {{S3AFileStatus}}. > So in the scope of {{S3guard}}, it should use {{S3AFileStatus}} in instead of {{FileStatus}} in {{PathMetadaa}} to avoid casting the types back and forth in S3A. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: common-issues-help@hadoop.apache.org