Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Date: Sun, 9 Oct 2016 09:29:20 +0000 (UTC)
From: "Huafeng Wang (JIRA)" <jira@apache.org>
To: common-issues@hadoop.apache.org
Message-ID: <JIRA.13006906.1474567013000.776370.1476005360580@Atlassian.JIRA>
In-Reply-To: <JIRA.13006906.1474567013000@Atlassian.JIRA>
References: <JIRA.13006906.1474567013000@Atlassian.JIRA> <JIRA.13006906.1474567013162@arcas>
Subject: [jira] [Commented] (HADOOP-13641) Update
 UGI#spawnAutoRenewalThreadForUserCreds to reduce indentation
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Sun, 09 Oct 2016 09:29:22 -0000


    [ https://issues.apache.org/jira/browse/HADOOP-13641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15559667#comment-15559667 ] 

Huafeng Wang commented on HADOOP-13641:
---------------------------------------

Hi [~drankye],
  Thanks for your review and I uploaded a new patch which fixed the check style and the issue you mentioned. Please help to review it.
 

> Update UGI#spawnAutoRenewalThreadForUserCreds to reduce indentation
> -------------------------------------------------------------------
>
>                 Key: HADOOP-13641
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13641
>             Project: Hadoop Common
>          Issue Type: Improvement
>            Reporter: Xiao Chen
>            Assignee: Huafeng Wang
>            Priority: Minor
>              Labels: newbie
>         Attachments: HADOOP-13641.1.patch, HADOOP-13641.2.patch
>
>
> From [~drankye]'s comment in HADOOP-13590:
> Could we return earlier at the beginning so we can avoid at least 2 level of indents and make the whole block more readable?
> {code}
>   /**Spawn a thread to do periodic renewals of kerberos credentials*/
>   private void spawnAutoRenewalThreadForUserCreds() {
>     if (isSecurityEnabled()) {
>       //spawn thread only if we have kerb credentials
>       if (user.getAuthenticationMethod() == AuthenticationMethod.KERBEROS &&
>           !isKeytab) {
> ...
> ...
>                              very deep nested ...
> ...
> {code}


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org