hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Xiao Chen (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HADOOP-13775) KMS Client does not encode key names in the URL path correctly
Date Mon, 31 Oct 2016 21:23:58 GMT

     [ https://issues.apache.org/jira/browse/HADOOP-13775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Xiao Chen updated HADOOP-13775:
-------------------------------
    Attachment: HADOOP-13775.01.patch

The current user of Java's [URLEncoder|https://docs.oracle.com/javase/7/docs/api/java/net/URLEncoder.html]
is incorrect, as that's for form encoding. Since ops like [getKeyMetadata|http://hadoop.apache.org/docs/r3.0.0-alpha1/hadoop-kms/index.html#Get_Key_Metadata],
the key name is part of the URL path, it should be URL-encoded. An example would be key name
with a space ' ' should be encoded as '%20' (URL encoded), not '+' (form encoded).

Updated unit tests too.

> KMS Client does not encode key names in the URL path correctly
> --------------------------------------------------------------
>
>                 Key: HADOOP-13775
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13775
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: kms
>    Affects Versions: 2.6.0
>            Reporter: Xiao Chen
>            Assignee: Xiao Chen
>              Labels: supportability
>         Attachments: HADOOP-13775.01.patch
>
>
> HADOOP-12962 fixed the KMS server to encode special characters correctly when they're
part of the [URI|https://docs.oracle.com/javase/7/docs/api/java/net/URI.html] query.
> It turns out they can also cause trouble when being the URI path. This time it's the
client-side that's broken.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message