hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Wang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-13722) Code cleanup -- ViewFileSystem and InodeTree
Date Sat, 15 Oct 2016 00:43:20 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-13722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15577015#comment-15577015
] 

Andrew Wang commented on HADOOP-13722:
--------------------------------------

I bet precommit bot is going to have a field day with the VFS code :) you can tell it predates
checkstyle turned on in precommit.

I see a few other small nits we could address:

* Unnecessary "static" on ResultKind, I think we should also have a newline after the closing
brace of this enum.
* Erratic indentation still on the getTargetFileSystem overrides
* TestViewFsConfig, indentation of the "new InodeTree" is off, maybe run the auto-formatter
on this entire file.
* ViewFileSystem#MountPoint, want to turn those slash comments into javadoc comments?

> Code cleanup -- ViewFileSystem and InodeTree
> --------------------------------------------
>
>                 Key: HADOOP-13722
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13722
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 3.0.0-alpha2
>            Reporter: Manoj Govindassamy
>            Assignee: Manoj Govindassamy
>            Priority: Minor
>         Attachments: HADOOP-13722.01.patch
>
>
> ViewFileSystem is the FileSystem for viewfs:// and its uses InodeTree to manage the mount
points. These files being very old, don't quit adhere to the styling and coding standards.
Will do code cleanup of these files as part of this jira. No new functionalities or tests
will be added as part of this jira. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message