hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Nauroth (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-13675) Bug in return value for delete() calls in WASB
Date Thu, 06 Oct 2016 21:35:20 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-13675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15553249#comment-15553249
] 

Chris Nauroth commented on HADOOP-13675:
----------------------------------------

Hello [~dchickabasapa].  This patch basically looks good.  A few comments:

* Please do not subclass {{NativeAzureFileSystemBaseTest}} for the new test suite.  This causes
it to re-run every {{@Test}} from the base class, which adds ~5 minutes of redundant testing
to the build.  Instead, please subclass {{AbstractWasbTestBase}}.  See HADOOP-13459 if you'd
like more details on this.
* I suspect pre-commit will show Checkstyle warnings in {{TestNativeAzureFileSystemConcurrencyLive}}.
 Please indent by 2 spaces.  (Do not use tabs.)
* After applying the patch, I saw test failures in {{TestNativeAzureFileSystemMocked}},{{TestOutOfBandAzureBlobOperations}}
and {{TestOutOfBandAzureBlobOperationsLive}}.  Would you please investigate these and fix
them?

When posting patches, please run all tests, including the tests against the live Azure Storage
service, and state that you ran all tests successfully before posting the patch.  Thank you.

> Bug in return value for delete() calls in WASB
> ----------------------------------------------
>
>                 Key: HADOOP-13675
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13675
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: azure, fs/azure
>    Affects Versions: 2.8.0
>            Reporter: Dushyanth
>            Assignee: Dushyanth
>             Fix For: 2.9.0
>
>         Attachments: HADOOP-13675.001.patch
>
>
> Current implementation of WASB does not correctly handle multiple threads/clients calling
delete on the same file. The expected behavior in such scenarios is only one of the thread
should delete the file and return true, while all other threads should receive false. However
in the current implementation even though only one thread deletes the file, multiple clients
incorrectly get "true" as the return from delete() call..



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message