hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jingcheng Du (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-13702) Add a new instrumented read-write lock
Date Tue, 11 Oct 2016 02:42:20 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-13702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15564228#comment-15564228

Jingcheng Du commented on HADOOP-13702:

Thanks for the comments [~xiaochen]!

{{InstrumentedLock}} which is also in branch-2.8 is now in HDFS, I moved the {{InstrumentedReadLock}}
and {{InstrumentedWriteLock}} back to hdfs to align them with {{InstrumentedLock}} together.
I can move the read-write lock to COMMON in the next patch.
It is true to extend {{InstrumentedLock}} can avoid the code duplicated, but the read-write
lock code cannot be in COMMON anymore since {{InstrumentedLock}} is in HDFS.
And is it more straightforward if we use a InstrumentedReadLock/InstrumentedWriteLock as ReadLock/WriteLock,
and use readLock/writeLock methods in InstrumentedReadWriteLock to get them? :)
Please advise. Thanks a lot.

> Add a new instrumented read-write lock
> --------------------------------------
>                 Key: HADOOP-13702
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13702
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: common
>            Reporter: Jingcheng Du
>            Assignee: Jingcheng Du
>         Attachments: HDFS-10924-2.patch, HDFS-10924-3.patch, HDFS-10924-4.patch, HDFS-10924-5.patch,
> Add a new instrumented read-write lock in hadoop common, so that the HDFS-9668 can use
this to improve the locking in FsDatasetImpl

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org

View raw message