hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Wei-Chiu Chuang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-13660) Upgrade commons-configuration version
Date Mon, 24 Oct 2016 18:30:58 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-13660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15602819#comment-15602819
] 

Wei-Chiu Chuang commented on HADOOP-13660:
------------------------------------------

Hey [~mackrorysd] thanks a lot for putting these together.  It mostly looks good with just
a few nits:
* IOException is imported but not used in MetricsConfig.java
* 
{code:title=MetricsConfig#create}
        // Commons Configuration defines the message text when file not found
        if (e.getMessage().startsWith("Could not locate")) {
          continue;
        }
{code}
Depending on exception message is generally risky. Would it be possible to add a regression
test? Or is it already covered by existing unit tests?
* This conversion is a little bit concerning:
{code}
conf.setListDelimiterHandler(new DefaultListDelimiterHandler(','));
{code}
 According to https://commons.apache.org/proper/commons-configuration/userguide/upgradeto2_0.html#Accessing_Configuration_Properties
{{DefaultListDelimiterHandler}} is not 100% compatible with the old behavior (even though
the old one is inconsistent). Instead, {{LegacyListDelimiterHandler}} is said to preserve
old behavior. Want to call this out so we can study it further.


> Upgrade commons-configuration version
> -------------------------------------
>
>                 Key: HADOOP-13660
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13660
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: build
>    Affects Versions: 3.0.0-alpha2
>            Reporter: Sean Mackrory
>            Assignee: Sean Mackrory
>         Attachments: HADOOP-13660-configuration2.001.patch, HADOOP-13660.001.patch, HADOOP-13660.002.patch,
HADOOP-13660.003.patch
>
>
> We're currently pulling in version 1.6 - I think we should upgrade to the latest 1.10.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message