hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Steve Loughran (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-12977) s3a to handle delete("/", true) robustly
Date Fri, 07 Oct 2016 11:54:20 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-12977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15554897#comment-15554897
] 

Steve Loughran commented on HADOOP-12977:
-----------------------------------------

Patch applied to trunk and branch-2; the trunk patch was simply done by skipping the s3 test;
git lets you do this with ease

{code}
git apply -3 --verbose --whitespace=fix --exclude hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/contract/s3/ITestS3ContractRootDir.java
 HADOOP-12977-branch-2-006.patch 
{code}

Branch-2.8 is another matter; I will do that quickly and attach under here again

> s3a to handle delete("/", true) robustly
> ----------------------------------------
>
>                 Key: HADOOP-12977
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12977
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs/s3
>    Affects Versions: 2.9.0
>            Reporter: Steve Loughran
>            Assignee: Steve Loughran
>            Priority: Minor
>         Attachments: HADOOP-12977-001.patch, HADOOP-12977-002.patch, HADOOP-12977-branch-2-002.patch,
HADOOP-12977-branch-2-002.patch, HADOOP-12977-branch-2-003.patch, HADOOP-12977-branch-2-004.patch,
HADOOP-12977-branch-2-005.patch, HADOOP-12977-branch-2-006.patch
>
>
> if you try to delete the root directory on s3a, you get politely but firmly told you
can't
> {code}
> 2016-03-30 12:01:44,924 INFO  s3a.S3AFileSystem (S3AFileSystem.java:delete(638)) - s3a
cannot delete the root directory
> {code}
> The semantics of {{rm -rf "/"}} are defined, they are "delete everything underneath,
while preserving the root dir itself".
> # s3a needs to support this.
> # this skipped through the FS contract tests in {{AbstractContractRootDirectoryTest}};
the option of whether deleting / works or not should be made configurable.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message