hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ravi Prakash (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-10075) Update jetty dependency to version 9
Date Tue, 18 Oct 2016 02:34:59 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-10075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15584205#comment-15584205
] 

Ravi Prakash commented on HADOOP-10075:
---------------------------------------

Thanks Robert! 

* Why did you have to add {{ep.getPort() == -2}} in {{HttpServer2.Builder.build()}}? The javadoc
for URI never claims to return a -2. Is it bleeding in from {{ServerConnector.getLocalPort()}}
somehow?
* {{HttpServer2.createDefaultChannelConnector()}} has started taking a server as an argument.
Is that really necessary? Or are we always asking to pass in an instance of {{Server}} to
this method that we already have access to?

My notes (and not necessarily questions, but if you have more info, it'd be great to document
here):
* http://www.eclipse.org/jetty/documentation/current/architecture.html#basic-architecture
and http://www.eclipse.org/jetty/documentation/current/embedding-jetty.html are good pages
to read up.
* {code}      conn.addFirstConnectionFactory(new SslConnectionFactory(sslContextFactory,
          HttpVersion.HTTP_1_1.asString()));
{code} http://archive.eclipse.org/jetty/9.0.0.M3/apidocs/org/eclipse/jetty/server/ssl/SslSelectChannelConnector.html
suggests to use SelectChannelConnector . Couldn't find any documentation on how to do that.
* {{c.setLowResourceMaxIdleTime(10000);}} has been changed to {{c.setIdleTimeout(10000);}}
This just means that timeout will occur after 10s whether or not there were more than LowResourcesConnections.
I'm fine with this change.
* We haven't set {{c.setResolveNames(false);}}[This thread|https://dev.eclipse.org/mhonarc/lists/jetty-users/msg07284.html]
claims that by default names will not be resolved, so I'm fine with this change. Tagging [~mshen]
who had put in original arguments.
* {{addNoCacheFilter(webAppContext);}} was changed to {{addNoCacheFilter(logContext);}} Was
this a bug earlier?
* {{addInternalServlet()}} removes existing path bindings now. I don't see what else we could
do about it. Fine by me.


> Update jetty dependency to version 9
> ------------------------------------
>
>                 Key: HADOOP-10075
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10075
>             Project: Hadoop Common
>          Issue Type: Improvement
>    Affects Versions: 2.2.0, 2.6.0
>            Reporter: Robert Rati
>            Assignee: Robert Kanter
>            Priority: Critical
>         Attachments: HADOOP-10075-002-wip.patch, HADOOP-10075.003.patch, HADOOP-10075.004.patch,
HADOOP-10075.005.patch, HADOOP-10075.006.patch, HADOOP-10075.007.patch, HADOOP-10075.008.patch,
HADOOP-10075.009.patch, HADOOP-10075.patch
>
>
> Jetty6 is no longer maintained.  Update the dependency to jetty9.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message