Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 811E1200B8D for ; Fri, 23 Sep 2016 22:40:22 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 7FB8A160AD0; Fri, 23 Sep 2016 20:40:22 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id BB6E4160ACF for ; Fri, 23 Sep 2016 22:40:21 +0200 (CEST) Received: (qmail 36550 invoked by uid 500); 23 Sep 2016 20:40:20 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 36521 invoked by uid 99); 23 Sep 2016 20:40:20 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 23 Sep 2016 20:40:20 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 89B7E2C0B06 for ; Fri, 23 Sep 2016 20:40:20 +0000 (UTC) Date: Fri, 23 Sep 2016 20:40:20 +0000 (UTC) From: "Chen Liang (JIRA)" To: common-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HADOOP-13644) Replace config key literal strings with config key names MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Fri, 23 Sep 2016 20:40:22 -0000 [ https://issues.apache.org/jira/browse/HADOOP-13644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15517512#comment-15517512 ] Chen Liang commented on HADOOP-13644: ------------------------------------- I did some checking and it turns out there are actually a lot of usages like this in different modules. Based on some offline discussion with [~liuml07], we decided to fix them in a step-by-step fashion. Here the v001 patch only tries to resolve the use of {{"io.file.buffer.size"}} in hadoop-commons. Will file other JIRAs to solve other usages like such. > Replace config key literal strings with config key names > --------------------------------------------------------- > > Key: HADOOP-13644 > URL: https://issues.apache.org/jira/browse/HADOOP-13644 > Project: Hadoop Common > Issue Type: Bug > Components: conf > Reporter: Mingliang Liu > Assignee: Chen Liang > Priority: Minor > Attachments: HADOOP-13644.001.patch > > > There are some places that use config key literal strings instead of config key names, e.g. > {code:title=IOUtils.java} > copyBytes(in, out, conf.getInt("io.file.buffer.size", 4096), true); > {code} > We should replace places like this. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: common-issues-help@hadoop.apache.org