Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Date: Mon, 12 Sep 2016 04:36:20 +0000 (UTC)
From: "Masatake Iwasaki (JIRA)" <jira@apache.org>
To: common-issues@hadoop.apache.org
Message-ID: <JIRA.12751851.1414720623000.544445.1473654980849@Atlassian.JIRA>
In-Reply-To: <JIRA.12751851.1414720623000@Atlassian.JIRA>
References: <JIRA.12751851.1414720623000@Atlassian.JIRA> <JIRA.12751851.1414720623677@arcas>
Subject: [jira] [Commented] (HADOOP-11252) RPC client does not time out by
 default
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Mon, 12 Sep 2016 04:36:23 -0000


    [ https://issues.apache.org/jira/browse/HADOOP-11252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15483040#comment-15483040 ] 

Masatake Iwasaki commented on HADOOP-11252:
-------------------------------------------

bq. Should we accept the change of the value from program?

I think there is no usecase for applications and donstream projects. {{org.apache.hadoop.ipc}} is [marked as LimitedPrivate|https://github.com/apache/hadoop/blob/branch-2/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/package-info.java#L18] and is not publiched in [javadoc|https://hadoop.apache.org/docs/r2.7.2/api/index.html]. Though HBase is in the audience, HBase has its own ipc code now.


> RPC client does not time out by default
> ---------------------------------------
>
>                 Key: HADOOP-11252
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11252
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: ipc
>    Affects Versions: 2.5.0
>            Reporter: Wilfred Spiegelenburg
>            Assignee: Masatake Iwasaki
>            Priority: Critical
>             Fix For: 2.8.0, 2.7.3, 2.6.4, 3.0.0-alpha1
>
>         Attachments: HADOOP-11252.002.patch, HADOOP-11252.003.patch, HADOOP-11252.004.patch, HADOOP-11252.patch
>
>
> The RPC client has a default timeout set to 0 when no timeout is passed in. This means that the network connection created will not timeout when used to write data. The issue has shown in YARN-2578 and HDFS-4858. Timeouts for writes then fall back to the tcp level retry (configured via tcp_retries2) and timeouts between the 15-30 minutes. Which is too long for a default behaviour.
> Using 0 as the default value for timeout is incorrect. We should use a sane value for the timeout and the "ipc.ping.interval" configuration value is a logical choice for it. The default behaviour should be changed from 0 to the value read for the ping interval from the Configuration.
> Fixing it in common makes more sense than finding and changing all other points in the code that do not pass in a timeout.
> Offending code lines:
> https://github.com/apache/hadoop/blob/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java#L488
> and 
> https://github.com/apache/hadoop/blob/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java#L350


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org