hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-13658) Replace config key literal strings with config key names I: hadoop common
Date Wed, 28 Sep 2016 01:51:20 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-13658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15528076#comment-15528076
] 

Hudson commented on HADOOP-13658:
---------------------------------

SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10502 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/10502/])
HADOOP-13658. Replace config key literal strings with names I: hadoop (liuml07: rev 9a44a832a99eb967aa4e34338dfa75baf35f9845)
* (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/IOUtils.java
* (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/SequenceFile.java
* (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java
* (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/BloomMapFile.java
* (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/ftp/FTPFileSystem.java
* (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/MapFile.java
* (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/contract/ContractTestUtils.java
* (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/DefaultCodec.java
* (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/SocksSocketFactory.java
* (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/hash/Hash.java
* (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/GzipCodec.java
* (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/file/tfile/Compression.java
* (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/CommandWithDestination.java
* (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/BZip2Codec.java
* (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/LineReader.java


> Replace config key literal strings with config key names I: hadoop common
> -------------------------------------------------------------------------
>
>                 Key: HADOOP-13658
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13658
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: conf
>            Reporter: Chen Liang
>            Assignee: Chen Liang
>            Priority: Minor
>             Fix For: 2.8.0, 3.0.0-alpha2
>
>         Attachments: HADOOP-13658.001.patch, HADOOP-13658.002.patch, HADOOP-13658.003.patch
>
>
> In Hadoop Common, there are several places where the config keys are used by the literal
strings instead of their names as in configuration key classes. The default values have the
same issue. For example
> {code:title=in o.a.h.i.f.t.Compression.java}
> conf.setInt("io.compression.codec.lzo.buffersize", 64 * 1024);
> {code}
> should be
> {code}
> conf.setInt(
>     CommonConfigurationKeys.IO_COMPRESSION_CODEC_LZO_BUFFERSIZE_KEY,
>     CommonConfigurationKeys.IO_COMPRESSION_CODEC_LZO_BUFFERSIZE_DEFAULT);
> {code}
> instead



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message