hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chen Liang (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HADOOP-13658) Replace config key literal strings with config key names I: hadoop common
Date Tue, 27 Sep 2016 23:39:20 GMT

     [ https://issues.apache.org/jira/browse/HADOOP-13658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Chen Liang updated HADOOP-13658:
--------------------------------
    Attachment: HADOOP-13658.003.patch

Thanks [~liuml07] for the review and the comments! Uploaded v003 patch to use static import
instead.

> Replace config key literal strings with config key names I: hadoop common
> -------------------------------------------------------------------------
>
>                 Key: HADOOP-13658
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13658
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: conf
>            Reporter: Chen Liang
>            Assignee: Chen Liang
>            Priority: Minor
>         Attachments: HADOOP-13658.001.patch, HADOOP-13658.002.patch, HADOOP-13658.003.patch
>
>
> In Hadoop Common, there are several places where the config keys are used by the literal
strings instead of their names as in configuration key classes. The default values have the
same issue. For example
> {code:title=in o.a.h.i.f.t.Compression.java}
> conf.setInt("io.compression.codec.lzo.buffersize", 64 * 1024);
> {code}
> should be
> {code}
> conf.setInt(
>     CommonConfigurationKeys.IO_COMPRESSION_CODEC_LZO_BUFFERSIZE_KEY,
>     CommonConfigurationKeys.IO_COMPRESSION_CODEC_LZO_BUFFERSIZE_DEFAULT);
> {code}
> instead



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message