hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-13614) Purge some superfluous/obsolete S3 FS tests that are slowing test runs down
Date Fri, 30 Sep 2016 17:32:20 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-13614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15536535#comment-15536535
] 

ASF GitHub Bot commented on HADOOP-13614:
-----------------------------------------

GitHub user steveloughran opened a pull request:

    https://github.com/apache/hadoop/pull/132

    HADOOP-13614 superfluous tests

    
    * where possible give all the s3a tests the superclass of {{AbstractS3ATestBase}}, clean
up children.
    * ITestS3AFileSystemContract has path logic reworked *so test can run in parallel*
    * fixed up yarn test to work in parallel too, along with BlockingThreadPool and FastOutputStream
    * on the files changed, moved the copyright comment to being a simple comment rather than
a javadoc one.
    
    This conflicts a bit with HADOOP-13560; this patch should go in first and then I'll address
the diffs

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/steveloughran/hadoop s3/HADOOP-13614-superfluous-tests

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/hadoop/pull/132.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #132
    
----
commit 0c62c670549a18c5cfdb44d940f36a98bf6a1168
Author: Steve Loughran <stevel@apache.org>
Date:   2016-09-15T08:37:05Z

    HADOOP-13614: cut some needless, slower S3A tests

commit 3a4b5640814f0d0dc76461fa502cd354eef19bce
Author: Steve Loughran <stevel@apache.org>
Date:   2016-09-16T13:40:58Z

    HADOOP-13614; fix tests to compile, review all tests, clean slightly and move timing of
upload/download times and bandwidth to contract tests

commit 68b03bef79d25d71549da9ca72ebcdf7e1434938
Author: Steve Loughran <stevel@apache.org>
Date:   2016-09-30T17:28:14Z

    HADOOP-13614: patch 002.
    -where possible give all the s3a tests the superclass of {{AbstractS3ATestBase}}, clean
up children.
    -ITestS3AFileSystemContract has path logic reworked *so test can run in parallel*
    -fixed up yarn test to work in parallel too, along with BlockingThreadPool and FastOutputStream
    -on the files changed, moved the copyright comment to being a simple comment rather than
a javadoc one.
    
    This conflicts a bit with HADOOP-13560; this patch should go in first and then I'll address
the diffs

----


> Purge some superfluous/obsolete S3 FS tests that are slowing test runs down
> ---------------------------------------------------------------------------
>
>                 Key: HADOOP-13614
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13614
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs/s3, test
>    Affects Versions: 2.9.0
>            Reporter: Steve Loughran
>            Assignee: Steve Loughran
>            Priority: Minor
>         Attachments: HADOOP-13614-branch-2-001.patch, HADOOP-13614-branch-2-002.patch,
HADOOP-13614-branch-2-002.patch, testrun.txt
>
>
> Some of the slow test cases contain tests that are now obsoleted by newer ones. For example,
{{ITestS3ADeleteManyFiles}} has the test case {{testOpenCreate()}} which writes then reads
files up 25 MB.
> Have a look at which of the s3a tests are taking time, review them to see if newer tests
have superceded the slow ones; and cut them where appropriate.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message