hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tsuyoshi Ozawa (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (HADOOP-13579) Fix source-level compatibility after HADOOP-11252
Date Tue, 06 Sep 2016 23:54:20 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-13579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15468980#comment-15468980
] 

Tsuyoshi Ozawa edited comment on HADOOP-13579 at 9/6/16 11:53 PM:
------------------------------------------------------------------

[~iwasakims] thanks for your review!
{quote}
checkstyle suggests public static final rather than final public static.
{quote}
I'm okay to fix checkstyle, but I fixed so because [the coding style in the file is so|https://github.com/apache/hadoop/blob/23abb09c1f979d8c18ece81e32630a35ed569399/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java#L129],
based on [Hadoop Coding Style|https://wiki.apache.org/hadoop/CodeReviewChecklist]. 

{quote}
changes to existing code: maintains existing style
{quote}

Can we go with v2 patch? Or, should we fix checkstyle?



was (Author: ozawa):
[~iwasakims] thanks for your review!
{quote}
checkstyle suggests public static final rather than final public static.
{quote}
I fixed so because [the coding style in the file is so|https://github.com/apache/hadoop/blob/23abb09c1f979d8c18ece81e32630a35ed569399/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java#L129],
based on [Hadoop Coding Style|https://wiki.apache.org/hadoop/CodeReviewChecklist]. 

{quote}
changes to existing code: maintains existing style
{quote}



> Fix source-level compatibility after HADOOP-11252
> -------------------------------------------------
>
>                 Key: HADOOP-13579
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13579
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 2.7.3, 2.6.4
>            Reporter: Akira Ajisaka
>            Assignee: Tsuyoshi Ozawa
>            Priority: Blocker
>         Attachments: HADOOP-13579-branch-2.6.001.patch, HADOOP-13579-branch-2.6.002.patch,
HADOOP-13579-branch-2.7.001.patch, HADOOP-13579-branch-2.7.002.patch
>
>
> Reported by [~chiwanpark]
> bq. Since 2.7.3 release, Client.get/setPingInterval is changed from public to package-private.
> bq. Giraph is one of broken examples for this changes. (https://github.com/apache/giraph/blob/release-1.0/giraph-core/src/main/java/org/apache/giraph/job/GiraphJob.java#L202)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message