hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aaron Fabbri (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (HADOOP-13448) S3Guard: Define MetadataStore interface.
Date Thu, 08 Sep 2016 23:57:21 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-13448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15475388#comment-15475388
] 

Aaron Fabbri edited comment on HADOOP-13448 at 9/8/16 11:56 PM:
----------------------------------------------------------------

bq. Yes, that makes sense. Would both get and put change to work with PathMetadata instead
of a raw FileStatus? I think so. I can update the patch one more time if you agree.

It feels like both should use PathMetadata for symmetry.. Then again, put(PathMetadata isDeleted=true)
should be disallowed (IllegalArgumentException?).. so I could go either way on this.  (isDeleted
doesn't exist yet but I plan to add it with testing / in-memory patches)

Yep, I'm cool with you updating patch.

I'm +1 on this.. After you post above updates  I'll rebase my MetadataStore unit test and
in-memory implementation and will try to get patches out for those tomorrow.



was (Author: fabbri):
bq. Yes, that makes sense. Would both get and put change to work with PathMetadata instead
of a raw FileStatus? I think so. I can update the patch one more time if you agree.

It feels like both should use PathMetadata for symmetry.. Then again, put(PathMetadata isDeleted=true)
should be disallowed (IllegalArgumentException?).. so I could go either way on this.

Yep, I'm cool with you updating patch.

I'm +1 on this.. After you post above updates  I'll rebase my MetadataStore unit test and
in-memory implementation and will try to get patches out for those tomorrow.


> S3Guard: Define MetadataStore interface.
> ----------------------------------------
>
>                 Key: HADOOP-13448
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13448
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs/s3
>            Reporter: Chris Nauroth
>            Assignee: Chris Nauroth
>         Attachments: HADOOP-13448-HADOOP-13345.001.patch, HADOOP-13448-HADOOP-13345.002.patch,
HADOOP-13448-HADOOP-13345.003.patch, HADOOP-13448-HADOOP-13345.004.patch
>
>
> Define the common interface for metadata store operations.  This is the interface that
any metadata back-end must implement in order to integrate with S3Guard.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message