hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Nauroth (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HADOOP-13448) S3Guard: Define MetadataStore interface.
Date Thu, 08 Sep 2016 23:43:20 GMT

     [ https://issues.apache.org/jira/browse/HADOOP-13448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

Chris Nauroth updated HADOOP-13448:
    Attachment: HADOOP-13448-HADOOP-13345.004.patch

bq. Should this be "return Collections.unmodifiableCollection(listMap.values())" )?

Yes, good idea.  I made this change and added a test for it.

bq. I think this function will change to expose the same PathMetadata return value. Thoughts?

Yes, that makes sense.  Would both {{get}} and {{put}} change to work with {{PathMetadata}}
instead of a raw {{FileStatus}}?  I think so.  I can update the patch one more time if you

bq. So, if the path exists but dir is empty, we get a DirListingMetadata with an empty list
of children.

I incorporated your JavaDoc change.  I agree that returning {{null}} is preferrable over throwing

> S3Guard: Define MetadataStore interface.
> ----------------------------------------
>                 Key: HADOOP-13448
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13448
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs/s3
>            Reporter: Chris Nauroth
>            Assignee: Chris Nauroth
>         Attachments: HADOOP-13448-HADOOP-13345.001.patch, HADOOP-13448-HADOOP-13345.002.patch,
HADOOP-13448-HADOOP-13345.003.patch, HADOOP-13448-HADOOP-13345.004.patch
> Define the common interface for metadata store operations.  This is the interface that
any metadata back-end must implement in order to integrate with S3Guard.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org

View raw message