hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "chillon_m (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HADOOP-13306) add filter doesnot check if it exists in HttpServer
Date Mon, 12 Sep 2016 06:20:20 GMT

     [ https://issues.apache.org/jira/browse/HADOOP-13306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

chillon_m updated HADOOP-13306:
-------------------------------
    Description: 
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer2.java
line-705(hadoop2.5.2):defineFilter() doesnot check filter if it exists.we need check if it
exists before add it.so,ervery request/response maybe dealed by same filter many times,maybe
affect performance

another,No_Cache_Filter added twice when create a HttpServer2 object.I think addDefaultApps()
 invoke addNoCacheFilter() is unnecessary.because addNoCacheFilter() has already been invoked
by createWebAppContext()  in httpServer2 constructor method.every request invoke twice cachefilter.

  was:
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer2.java
line-705:defineFilter() doesnot check filter if it exists.we need check if it exists before
add it.so,ervery request/response maybe dealed by same filter many times,maybe affect performance

another,No_Cache_Filter added twice when create a HttpServer2 object.I think addDefaultApps()
 invoke addNoCacheFilter() is unnecessary.because addNoCacheFilter() has already been invoked
by createWebAppContext()  in httpServer2 constructor method.every request invoke twice cachefilter.


> add filter doesnot check if it exists in HttpServer
> ---------------------------------------------------
>
>                 Key: HADOOP-13306
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13306
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 2.5.2, 2.7.2, 2.7.3, 2.6.4, 3.0.0-alpha1
>            Reporter: chillon_m
>            Priority: Minor
>         Attachments: 0001-HADOOP-13306(hadoop2.5.2).patch
>
>
> hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer2.java
> line-705(hadoop2.5.2):defineFilter() doesnot check filter if it exists.we need check
if it exists before add it.so,ervery request/response maybe dealed by same filter many times,maybe
affect performance
> another,No_Cache_Filter added twice when create a HttpServer2 object.I think addDefaultApps()
 invoke addNoCacheFilter() is unnecessary.because addNoCacheFilter() has already been invoked
by createWebAppContext()  in httpServer2 constructor method.every request invoke twice cachefilter.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message