Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Date: Tue, 16 Aug 2016 23:19:20 +0000 (UTC)
From: "Chris Nauroth (JIRA)" <jira@apache.org>
To: common-issues@hadoop.apache.org
Message-ID: <JIRA.12995102.1470374202000.323680.1471389560715@Atlassian.JIRA>
In-Reply-To: <JIRA.12995102.1470374202000@Atlassian.JIRA>
References: <JIRA.12995102.1470374202000@Atlassian.JIRA> <JIRA.12995102.1470374202425@arcas>
Subject: [jira] [Commented] (HADOOP-13470) GenericTestUtils$LogCapturer is
 flaky
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Tue, 16 Aug 2016 23:19:22 -0000


    [ https://issues.apache.org/jira/browse/HADOOP-13470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15423577#comment-15423577 ] 

Chris Nauroth commented on HADOOP-13470:
----------------------------------------

bq. A simple fix is to use default {{PatternLayout}} only if the {{stdout}} and {{console}} appender are not defined.

That sounds perfect.  That would be backward-compatible for any existing tests that rely on a specific pattern in log4j.properties.  Thanks!  Please feel free to notify me for code review on the new patch, and I'll try {{TestFileSystemOperationsWithThreads}} with it.

> GenericTestUtils$LogCapturer is flaky
> -------------------------------------
>
>                 Key: HADOOP-13470
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13470
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: test, util
>    Affects Versions: 2.8.0
>            Reporter: Mingliang Liu
>            Assignee: Mingliang Liu
>              Labels: reviewed
>             Fix For: 2.8.0
>
>         Attachments: HADOOP-13470.000.patch, HADOOP-13470.001.patch
>
>
> {{GenericTestUtils$LogCapturer}} is useful for assertions against service logs. However it should be fixed in following aspects:
> # In the constructor, it uses the stdout appender's layout.
> {code}
> Layout layout = Logger.getRootLogger().getAppender("stdout").getLayout();
> {code}
> However, the stdout appender may be named "console" or alike which makes the constructor throw NPE. Actually the layout does not matter and we can use a default pattern layout that only captures application logs.
> # {{stopCapturing()}} method is not working. The major reason is that the {{appender}} internal variable is never assigned and thus removing it to stop capturing makes no sense.
> # It does not support {{org.slf4j.Logger}} which is preferred to log4j in many modules.
> # There is no unit test for it.
> This jira is to address these.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org