hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-13559) Remove close() within try-with-resources in ChecksumFileSystem/ChecksumFs classes
Date Mon, 29 Aug 2016 20:21:20 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-13559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15446951#comment-15446951
] 

Hudson commented on HADOOP-13559:
---------------------------------

SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10367 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/10367/])
HADOOP-13559. Remove close() within try-with-resources in (liuml07: rev 6fcb04c1780ac3dca5b986f1bcd558fffccb3eb9)
* (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/ChecksumFileSystem.java
* (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/ChecksumFs.java


> Remove close() within try-with-resources in ChecksumFileSystem/ChecksumFs classes
> ---------------------------------------------------------------------------------
>
>                 Key: HADOOP-13559
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13559
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: fs
>    Affects Versions: 2.8.0, 2.9.0
>            Reporter: Aaron Fabbri
>            Assignee: Aaron Fabbri
>            Priority: Minor
>             Fix For: 2.8.0
>
>         Attachments: HADOOP-13559-001.patch
>
>
> My colleague noticed that HADOOP-12994 introduced to places where close() was still called
manually within a try-with-resources block.
> I'll attach a patch to remove the manual close() calls. 
> These extra calls to close() are probably safe, as InputStream is a Closable, not AutoClosable
(the later does not specify close() as idempotent).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message