hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jing Zhao (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-13546) Have TryOnceThenFail override equals and hashCode
Date Thu, 25 Aug 2016 19:56:21 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-13546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15437529#comment-15437529
] 

Jing Zhao commented on HADOOP-13546:
------------------------------------

Since for 2.x we only need to fix 2 retry policies, maybe we can finish the work in one jira?

For the current patch, the following code can be further simplified:
{code}
196	    public boolean equals(Object obj) {
197	      if (obj == null) {
198	        return false;
199	      }
200	
201	      if (obj == this) {
202	        return true;
203	      }
204	
205	      if (obj.getClass() == this.getClass()) {
206	        return true;
207	      }
208	
209	      return false;
210	    }
{code}

> Have TryOnceThenFail override equals and hashCode
> -------------------------------------------------
>
>                 Key: HADOOP-13546
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13546
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: ipc
>    Affects Versions: 2.7.0
>            Reporter: Xiaobing Zhou
>            Assignee: Xiaobing Zhou
>         Attachments: HADOOP-13546-HADOOP-13436.000.patch, HADOOP-13546-HADOOP-13436.001.patch
>
>
> Override #equals and #hashcode to ensure multiple instances are equivalent. They eventually
> share the same RPC connection given the other arguments of constructing ConnectionId
are
> the same.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message