hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Albert Chu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-13533) User cannot set empty HADOOP_SSH_OPTS environment variable option
Date Wed, 24 Aug 2016 17:13:21 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-13533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15435310#comment-15435310
] 

Albert Chu commented on HADOOP-13533:
-------------------------------------

Would it be better to make HADOOP_SSH_OPTS default to empty string?  I believe this was the
case in Hadoop 2.X.

If say a user has configured everything in .ssh/config, they have to knowingly set HADOOP_SSH_OPTS
to empty string to force it to be empty.  IMO this is the opposite of what most users would
think.  Most would think they have to set HADOOP_SSH_OPTS if they need to.

> User cannot set empty HADOOP_SSH_OPTS environment variable option
> -----------------------------------------------------------------
>
>                 Key: HADOOP-13533
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13533
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: scripts
>    Affects Versions: 3.0.0-alpha2
>            Reporter: Albert Chu
>            Assignee: Albert Chu
>            Priority: Minor
>
> In hadoop-functions.sh in the hadoop_basic_init function there is this initialization
of HADOOP_SSH_OPTS:
> {noformat}
> HADOOP_SSH_OPTS=${HADOOP_SSH_OPTS:-"-o BatchMode=yes -o StrictHostKeyChecking=no -o ConnectTimeout=10s"}
> {noformat}
> I believe this parameter substitution is a bug.  While most of the environment variables
set in the function are generally required for functionality (HADOOP_LOG_DIR, HADOOP_LOGFILE,
etc.) I don't believe HADOOP_SSH_OPTS is one of them.  If the user wishes to set HADOOP_SSH_OPTS
to an empty string (i.e. HADOOP_SSH_OPTS="") they should be able to.  But instead, this is
requiring HADOOP_SSH_OPTS to always be set to something.
> So I think the 
> {noformat}
> ":-"
> {noformat}
> in the above should be
> {noformat}
> "-"
> {noformat}
> Github pull request to be sent shortly.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message