hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kai Zheng (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-13504) Refactor jni_common to conform to C89 restrictions imposed by Visual Studio 2010
Date Thu, 18 Aug 2016 03:34:22 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-13504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15425858#comment-15425858
] 

Kai Zheng commented on HADOOP-13504:
------------------------------------

The patch LGTM and +1. Will commit it today.

> Refactor jni_common to conform to C89 restrictions imposed by Visual Studio 2010
> --------------------------------------------------------------------------------
>
>                 Key: HADOOP-13504
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13504
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: io
>            Reporter: SammiChen
>            Assignee: SammiChen
>         Attachments: HADOOP-13504-v1.patch
>
>
> Piece of code in jni_common declares variables after the first statement in function.
This behavior is not allowed in compilers, such as Visual Studio 2010, which only supports
C89 C standards. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message