hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Wei-Chiu Chuang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-13458) LoadBalancingKMSClientProvider#doOp should log IOException stacktrace
Date Wed, 03 Aug 2016 00:16:20 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-13458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15405072#comment-15405072
] 

Wei-Chiu Chuang commented on HADOOP-13458:
------------------------------------------

Hi [~vagarychen] thanks for the quick patch contribution!
In the spirit of code reuse, can you use {{StringUtils.stringifyException(ioe))}} instead?

> LoadBalancingKMSClientProvider#doOp should log IOException stacktrace
> ---------------------------------------------------------------------
>
>                 Key: HADOOP-13458
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13458
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: kms
>            Reporter: Wei-Chiu Chuang
>            Assignee: Chen Liang
>            Priority: Trivial
>              Labels: supportability
>         Attachments: HADOOP-13458.001.patch
>
>
> Sometimes it's relatively hard to comprehend the meaning of the exception message without
stacktrace. I think we should log the stacktrace too.
> {code}
> LOG.warn("KMS provider at [{}] threw an IOException [{}]!!",
>             provider.getKMSUrl(), ioe.getMessage());
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message