hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Akira Ajisaka (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-13444) Replace org.apache.commons.io.Charsets with java.nio.charset.StandardCharsets
Date Mon, 01 Aug 2016 02:04:21 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-13444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15401439#comment-15401439
] 

Akira Ajisaka commented on HADOOP-13444:
----------------------------------------

Thanks [~vincentpoon] for updating the patch! Mostly looks good to me.
Minor comment: Would you keep the order of import statements? For example, the following statements
{code:title=KeyProvider.java}
  import com.google.gson.stream.JsonWriter;
+ import java.nio.charset.StandardCharsets;
  import org.apache.hadoop.classification.InterfaceAudience;
{code}
can be replaced as follows:
{code:title=KeyProvider.java}
  import java.io.OutputStreamWriter;
+ import java.nio.charset.StandardCharsets;
  import java.security.NoSuchAlgorithmException;
{code}

> Replace org.apache.commons.io.Charsets with java.nio.charset.StandardCharsets
> -----------------------------------------------------------------------------
>
>                 Key: HADOOP-13444
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13444
>             Project: Hadoop Common
>          Issue Type: Improvement
>    Affects Versions: 2.7.2
>            Reporter: Vincent Poon
>            Priority: Minor
>         Attachments: HADOOP-13444.2.patch, HADOOP-13444.3.patch, HADOOP-13444.patch
>
>
> org.apache.commons.io.Charsets is deprecated in favor of java.nio.charset.StandardCharsets



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message