hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-13442) Optimize UGI group lookups
Date Thu, 04 Aug 2016 16:02:20 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-13442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15408011#comment-15408011
] 

Hudson commented on HADOOP-13442:
---------------------------------

SUCCESS: Integrated in Hadoop-trunk-Commit #10215 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/10215/])
HADOOP-13442. Optimize UGI group lookups. Contributed by Daryn Sharp. (kihwal: rev 94225152399e6e89fa7b4cff6d17d33e544329a3)
* hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/SecureIOUtils.java
* hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/UserGroupInformation.java
* hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/authorize/AccessControlList.java
* hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/TestUserGroupInformation.java
* hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFs.java
* hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/Groups.java
* hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java
* hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFileSystem.java


> Optimize UGI group lookups
> --------------------------
>
>                 Key: HADOOP-13442
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13442
>             Project: Hadoop Common
>          Issue Type: Improvement
>            Reporter: Daryn Sharp
>            Assignee: Daryn Sharp
>             Fix For: 2.8.0, 3.0.0-alpha2
>
>         Attachments: HADOOP-13442.patch
>
>
> {{UGI#getGroups}} and its usage is inefficient.  The list is unnecessarily converted
to multiple collections.
> For _every_ invocation, the {{List<String>}} from the group provider is converted
into a {{LinkedHashSet<String>}} (to de-dup), back to a {{String[]}}.  Then callers
testing for group membership convert back to a {{List<String>}}.  This should be done
once to reduce allocations.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message