hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Wei-Chiu Chuang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-13441) Document LdapGroupsMapping keystore password properties
Date Mon, 08 Aug 2016 20:47:20 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-13441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15412435#comment-15412435
] 

Wei-Chiu Chuang commented on HADOOP-13441:
------------------------------------------

Hi [~yuanbo] thanks again for the updated patch. This is largely good.

Couple of comments:

* instead of skipping the properties in TestCommonConfigurationFields, can you define these
property constants in {{CommonConfigurationKeysPublic}}, for example,
{code:title=CommonConfigurationKeysPublic.java}
public static final String  HADOOP_SECURITY_CREDENTIAL_PASSWORD_FILE_KEY = "hadoop.security.credstore.java-keystore-provider.password-file";
{code}
and then in AbstractJavaKeyStoreProvider.java:
{code:title=AbstractJavaKeyStoreProvider.java}
public static final String CREDENTIAL_PASSWORD_FILE_KEY = CommonConfigurationKeysPublic.HADOOP_SECURITY_CREDENTIAL_PASSWORD_FILE_KEY;
{code}

* hadoop.security.group.mapping.ldap.bind.password.file
{quote}
+    The path to a file containing the password of the bind user. If
+    the password is not configured in credential providers and the property
+    hadoop.security.group.mapping.ldap.bind.password, LDAPGroupsMapping
+    reads password from the file.
{quote}
should be "and the property hadoop.security.group.mapping.ldap.bind.password is not set"

Similarly the same change is needed for {{hadoop.security.group.mapping.ldap.ssl.keystore.password.file}}.

* GroupsMapping.md
{quote}
+In addition, specify the path to the keystore file for SSL connection in `hadoop.security.group.mapping.ldap.ssl.keystore`
and keystore password in `hadoop.security.group.mapping.ldap.ssl.keystore.password`, at the
same time, make sure `hadoop.security.credential.clear-text-fallback` is true.
+Alternatively, store the keystore password in a file, and point `hadoop.security.group.mapping.ldap.ssl.keystore.password.file`
to that file.
+For security purposes, this file should be readable only by the Unix user running the daemons,
and for preventing recursive dependency, this file should be a local file.
{quote}
This is good. Can you also add that "keystore password in `hadoop.security.group.mapping.ldap.ssl.keystore.password`"
is highly discouraged, because it exposes the password in the configuration file. Instead,
use the credential file and use `hadoop.security.group.mapping.ldap.ssl.keystore.password`
as the alias in the credential file for password, or use `hadoop.security.group.mapping.ldap.ssl.keystore.password.file`.

> Document LdapGroupsMapping keystore password properties
> -------------------------------------------------------
>
>                 Key: HADOOP-13441
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13441
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: security
>    Affects Versions: 2.6.0
>            Reporter: Wei-Chiu Chuang
>            Assignee: Yuanbo Liu
>            Priority: Minor
>              Labels: documentation
>         Attachments: HADOOP-13441.001.patch, HADOOP-13441.002.patch, HADOOP-13441.003.patch
>
>
> A few properties are not documented.
> {{hadoop.security.group.mapping.ldap.ssl.keystore.password}}
> This property is used as an alias to get password from credential providers, or, fall
back to using the value as password in clear text. There is also a caveat that credential
providers can not be a HDFS-based file system, as mentioned in HADOOP-11934, to prevent cyclic
dependency issue.
> This should be documented in core-default.xml and GroupsMapping.md
> {{hadoop.security.credential.clear-text-fallback}}
> This property controls whether or not to fall back to storing credential password as
cleartext.
> This should be documented in core-default.xml.
> {{hadoop.security.credential.provider.path}}
> This is mentioned in _CredentialProvider API Guide_, but not in core-default.xml
> The "Supported Features" in _CredentialProvider API Guide_ should link back to GroupsMapping.md#LDAP
Groups Mapping 
> {{hadoop.security.credstore.java-keystore-provider.password-file}}
> This is the password file to protect credential files.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message