hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sangjin Lee (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-13410) RunJar adds the content of the jar twice to the classpath
Date Tue, 16 Aug 2016 20:56:21 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-13410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15423366#comment-15423366
] 

Sangjin Lee commented on HADOOP-13410:
--------------------------------------

This should not have any bearing (one way or the other) on HADOOP-12728. If I understood correctly,
HADOOP-12728 seems to be an issue of the order between the jar in the argument and what's
in the underlying CLASSPATH or HADOOP_CLASSPATH. This JIRA concerns removing the redundant
entries for the jar, and does not affect the above ordering problem.

> RunJar adds the content of the jar twice to the classpath
> ---------------------------------------------------------
>
>                 Key: HADOOP-13410
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13410
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: util
>            Reporter: Sangjin Lee
>            Assignee: Yuanbo Liu
>             Fix For: 3.0.0-alpha2
>
>         Attachments: HADOOP-13410.001.patch
>
>
> Today when you run a "hadoop jar" command, the jar is unzipped to a temporary location
and gets added to the classloader.
> However, the original jar itself is still added to the classpath.
> {code}
>       List<URL> classPath = new ArrayList<>();
>       classPath.add(new File(workDir + "/").toURI().toURL());
>       classPath.add(file.toURI().toURL());
>       classPath.add(new File(workDir, "classes/").toURI().toURL());
>       File[] libs = new File(workDir, "lib").listFiles();
>       if (libs != null) {
>         for (File lib : libs) {
>           classPath.add(lib.toURI().toURL());
>         }
>       }
> {code}
> As a result, the contents of the jar are present in the classpath *twice* and are completely
redundant. Although this does not necessarily cause correctness issues, some stricter code
written to require a single presence of files may fail.
> I cannot think of a good reason why the jar should be added to the classpath if the unjarred
content was added to it. I think we should remove the jar from the classpath.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message