hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Wang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-13396) Allow pluggable audit loggers in KMS
Date Mon, 22 Aug 2016 17:53:21 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-13396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15431291#comment-15431291
] 

Andrew Wang commented on HADOOP-13396:
--------------------------------------

Splitting the patch sounds good to me. Few more comments:

* Still some lingering JSON references in the two log4j properties files
* Can we make the default value of the config key the classname, rather than empty? This way
users have an example.
* Should abort if a specified audit logger cannot be configured. Remember that the audit logger
is important for security, so we don't want to accidentally not log in the case of misconfiguration.
* I really like that comment on SimpleKMSAuditLogger. One grammar nit, "and will be haunted
by the consumer tools / developers", maybe you meant "will haunt consumer tools / developers"
?

> Allow pluggable audit loggers in KMS
> ------------------------------------
>
>                 Key: HADOOP-13396
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13396
>             Project: Hadoop Common
>          Issue Type: New Feature
>          Components: kms
>            Reporter: Xiao Chen
>            Assignee: Xiao Chen
>         Attachments: HADOOP-13396.01.patch, HADOOP-13396.02.patch, HADOOP-13396.03.patch,
HADOOP-13396.04.patch, HADOOP-13396.05.patch, HADOOP-13396.06.patch, HADOOP-13396.07.patch,
HADOOP-13396.08.patch
>
>
> Currently, KMS audit log is using log4j, to write a text format log.
> We should refactor this, so that people can easily add new format audit logs. The current
text format log should be the default, and all of its behavior should remain compatible.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message