hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Steve Loughran (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-13405) doc for “fs.s3a.acl.default” indicates incorrect values
Date Mon, 25 Jul 2016 13:51:20 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-13405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15391919#comment-15391919
] 

Steve Loughran commented on HADOOP-13405:
-----------------------------------------

I'd do a subclass of {{hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/AbstractS3ATestBase.java}},
try to create a filesystem instance with an ACL option set, assert that a file can be created,
read then deleted

Have a look at {{TestS3AEncryption}} to see how it does an encryption check; Something like
TestS3AAcls would be ideal.

(Don't feel worried about having to supply code, if you really don't want to do it, I won't
mind...it's just that your patch showed up that we aren't testing it at all, which is dangerous)

> doc for “fs.s3a.acl.default” indicates incorrect values
> -------------------------------------------------------
>
>                 Key: HADOOP-13405
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13405
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs/s3
>    Affects Versions: 2.8.0, 3.0.0-alpha2
>            Reporter: Shen Yinjie
>            Priority: Minor
>             Fix For: 3.0.0-alpha2
>
>         Attachments: HADOOP-13405.patch
>
>
> description for "fs.s3a.acl.default" indicates its values are "private,public-read....";
> when set value be public-read,and excute 'hdfs dfs -ls s3a://hdfs/'
> {{-ls: No enum constant com.amazonaws.services.s3.model.CannedAccessControlList.public-read}}
> while in amazon-sdk ,
> {code}
> public enum CannedAccessControlList {
>   Private("private"),
>   PublicRead("public-read"),
>   PublicReadWrite("public-read-write"),
>   AuthenticatedRead("authenticated-read"),
>   LogDeliveryWrite("log-delivery-write"),
>   BucketOwnerRead("bucket-owner-read"),
>   BucketOwnerFullControl("bucket-owner-full-control"); 
> {code}
> so values should be enum values as "Private","PublicRead"...
>  attached simple patch.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message