hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-13368) DFSOpsCountStatistics$OpType#fromSymbol and s3a.Statistic#fromSymbol should be O(1) operation
Date Fri, 15 Jul 2016 21:59:20 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-13368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15380191#comment-15380191
] 

Hudson commented on HADOOP-13368:
---------------------------------

SUCCESS: Integrated in Hadoop-trunk-Commit #10110 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/10110/])
HADOOP-13368. DFSOpsCountStatistics$OpType#fromSymbol and (jitendra: rev c2f9cd584cd7852b4745396494cc0c423eb645c1)
* hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/Statistic.java
* hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSOpsCountStatistics.java
* hadoop-hdfs-project/hadoop-hdfs-client/src/test/java/org/apache/hadoop/hdfs/TestDFSOpsCountStatistics.java


> DFSOpsCountStatistics$OpType#fromSymbol and s3a.Statistic#fromSymbol should be O(1) operation
> ---------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-13368
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13368
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs
>    Affects Versions: 2.8.0
>            Reporter: Mingliang Liu
>            Assignee: Mingliang Liu
>             Fix For: 2.8.0
>
>         Attachments: HADOOP-13368.000.patch, HADOOP-13368.001.patch
>
>
> To lookup, {{DFSOpsCountStatistics$OpType#fromSymbol}} and {{s3a.Statistic#fromSymbol}}
iterates all the enums to get the entry by its symbol. Usages of {{fromSymbol()}} include
{{isTracked()}} and {{getLong()}}. 
> As there are dozens of enum entries, it merits to make these two similar operations O(1)
complexity. This point is especially true if downstream app probes a dozen of stats in an
outer loop (see [TEZ-3331]).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message