hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jason Lowe (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-13362) DefaultMetricsSystem leaks the source name when a source unregisters
Date Mon, 11 Jul 2016 14:53:11 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-13362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15370910#comment-15370910

Jason Lowe commented on HADOOP-13362:

bq. However, I am still suspecting only backport part of YARN-5190 is enough as I didn't see
where we call ContainerMetrics.finish() in 2.7.3. Do I miss anything here?

It's definitely getting called in practice because after almost 2 million containers on that
node the only leak I saw was the metric source names.  The bean names and other stuff was
getting cleaned up as it should.  The metrics are getting cleaned up in the monitoring thread's
run() method:
        // Remove finished containers
        synchronized (containersToBeRemoved) {
          for (ContainerId containerId : containersToBeRemoved) {
            if (containerMetricsEnabled) {
                  containerId, containerMetricsPeriodMs,

> DefaultMetricsSystem leaks the source name when a source unregisters
> --------------------------------------------------------------------
>                 Key: HADOOP-13362
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13362
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: metrics
>    Affects Versions: 2.7.2
>            Reporter: Jason Lowe
>            Priority: Critical
> Ran across a nodemanager that was spending most of its time in GC.  Upon examination
of the heap most of the memory was going to the map of names in org.apache.hadoop.metrics2.lib.UniqueNames.
 In this case the map had almost 2 million entries.  Looking at a few of the map showed entries
like "ContainerResource_container_e01_1459548490386_8560138_01_002020", "ContainerResource_container_e01_1459548490386_2378745_01_000410",
> Looks like the ContainerMetrics for each container will cause a unique name to be registered
with UniqueNames and the name will never be unregistered.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org

View raw message