hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Allen Wittenauer (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (HADOOP-13341) Deprecate HADOOP_SERVERNAME_OPTS; replace with HADOOP_(subcommand)_OPTS
Date Fri, 08 Jul 2016 16:06:11 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-13341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15367731#comment-15367731
] 

Allen Wittenauer edited comment on HADOOP-13341 at 7/8/16 4:05 PM:
-------------------------------------------------------------------

One of the unexpected challenges here is ordering of operations:

* HADOOP\_OPTS
* HADOOP\_(subcommand)\_OPTS
* HADOOP\_CLIENTS\_OPTS

... is likely the ideal.  But the way HADOOP_CLIENT_OPTS are appended makes this particularly
tricky since it is done in the case statements.  It might be better to pull that code out
first, then deal with the various daemons.


was (Author: aw):
One of the unexpected challenges here is ordering of operations:

* HADOOP\_OPTS
* HADOOP\_(command)\_OPTS
* HADOOP\_CLIENTS\_OPTS

... is likely the ideal.  But the way HADOOP_CLIENT_OPTS are appended makes this particularly
tricky since it is done in the case statements.  It might be better to pull that code out
first, then deal with the various daemons.

> Deprecate HADOOP_SERVERNAME_OPTS; replace with HADOOP_(subcommand)_OPTS
> -----------------------------------------------------------------------
>
>                 Key: HADOOP-13341
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13341
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: scripts
>    Affects Versions: 3.0.0-alpha1
>            Reporter: Allen Wittenauer
>            Assignee: Allen Wittenauer
>
> Big features like YARN-2928 demonstrate that even senior level Hadoop developers forget
that daemons need a custom _OPTS env var.  We can replace all of the custom vars with generic
handling just like we do for the username check.
> For example, with generic handling in place:
> || Old Var || New Var ||
> | HADOOP_NAMENODE_OPTS | HDFS_namenode_OPTS |
> | YARN_RESOURCEMANAGER_OPTS | YARN_resourcemanager_OPTS |
> | n/a | YARN_timelineserverreader_OPTS |
> | n/a | HADOOP_distcp_OPTS |
> | n/a | MAPRED_distcp_OPTS |
> This makes it:
> a) consistent across the entire project
> b) consistent for every subcommand
> c) eliminates almost all of the custom appending in the case statements



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message