hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-13315) FileContext#umask is not initialized properly
Date Wed, 13 Jul 2016 00:40:20 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-13315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15374077#comment-15374077
] 

Hudson commented on HADOOP-13315:
---------------------------------

SUCCESS: Integrated in Hadoop-trunk-Commit #10084 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/10084/])
HADOOP-13315. FileContext#umask is not initialized properly. (John Zhuge (lei: rev a290a98b6ab2424ae9b7faab0ce9496d09ca46f3)
* hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileContext.java


> FileContext#umask is not initialized properly
> ---------------------------------------------
>
>                 Key: HADOOP-13315
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13315
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 2.6.0
>            Reporter: John Zhuge
>            Assignee: John Zhuge
>            Priority: Minor
>             Fix For: 2.8.0, 2.9.0, 3.0.0-alpha1
>
>         Attachments: HADOOP-13315.001.patch
>
>
> Notice field {{umask}} is not set to parameter {{theUmask}} and {{theUmask}} is unused.
> {code:title=FileContext.java}
>   private FileContext(final AbstractFileSystem defFs,
>     final FsPermission theUmask, final Configuration aConf) {
>     defaultFS = defFs;
>     umask = FsPermission.getUMask(aConf);
>     conf = aConf;
> ...
>   public static FileContext getFileContext(final AbstractFileSystem defFS,
>                     final Configuration aConf) {
>     return new FileContext(defFS, FsPermission.getUMask(aConf), aConf);
>   }
> {code}
> Proposal:
> * Set {{umask}} to {{theUmask}}. Since the only caller {{getFileContext}} already passes
the same value in {{theUmask}}, there is no change in behavior.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message