hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Kanter (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-13254) Create framework for configurable disk checkers
Date Mon, 11 Jul 2016 23:46:11 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-13254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15371918#comment-15371918
] 

Robert Kanter commented on HADOOP-13254:
----------------------------------------

I wasn't meaning to overly complicate things here.  My concern was that if someone went and
made their own plugin, that we don't want them to cause problems in the NM.  If we're going
to restrict the plugins to only Hadoop-supplied ones, which it looks like we are (re-looking
at the code, I see that we have Private audience and Unstable on the {{DiskValidator}} interface),
then I think it's fine to not worry about Threads, being super defensive, and those sorts
of things for now.

Given that, I'm +1 on the 008 patch.  I'll commit this tomorrow if nobody has any other comments.

> Create framework for configurable disk checkers
> -----------------------------------------------
>
>                 Key: HADOOP-13254
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13254
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: util
>            Reporter: Yufei Gu
>            Assignee: Yufei Gu
>         Attachments: HADOOP-13254.001.patch, HADOOP-13254.002.patch, HADOOP-13254.003.patch,
HADOOP-13254.004.patch, HADOOP-13254.005.patch, HADOOP-13254.006.patch, HADOOP-13254.007.patch,
HADOOP-13254.008.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message